Cleanup: Update references to BatchedMesh.maxGeometryCount #28694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methuselah96
commented
Jun 18, 2024
| @@ -752,7 +752,7 @@ class Object3D extends EventDispatcher { | |||
| sphereCenter: bound.sphere.center.toArray() | |||
| } ) ); | |||
|
|
|||
| object.maxGeometryCount = this._maxGeometryCount; | |||
| object.maxInstanceCount = this._maxInstanceCount; | |||
There was a problem hiding this comment.
I'm not sure how versioning works for toJSON(), does this require a major version bump of metadata.version on the outputted json?
There was a problem hiding this comment.
I would ignore this aspect for now. If someone complains, we can consider to apply a fallback on maxGeometryCount.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
BatchMeshed.maxGeometryCountwas renamed tomaxInstanceCountin #28462, but not all references were updated. This PR updates those references.