Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: wgslFn added alias and revision #28680

Merged
merged 2 commits into from
Jun 17, 2024
Merged

TSL: wgslFn added alias and revision #28680

merged 2 commits into from
Jun 17, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 17, 2024

Related issue: #28669

Description

WGSL only supports matrices with f32 or f16, so it removes, adds vector and matrix aliases and normalizes texture types to the TSL standard.
@sunag sunag added this to the r166 milestone Jun 17, 2024
@sunag sunag marked this pull request as ready for review June 17, 2024 17:13
@sunag sunag merged commit 2cccd20 into mrdoob:dev Jun 17, 2024
11 checks passed
@cmhhelgeson
Copy link
Contributor

Compute ping pong texture no longer works after this commit, but fixing it only requires changing 'textureStorage' to 'storageTexture', aligning it with the new syntax present in pull requests #28455 and #28531.
@cmhhelgeson cmhhelgeson mentioned this pull request Jun 17, 2024
Merged
@sunag sunag mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@sunag @cmhhelgeson