Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompressedArrayTexture: Rename addLayerUpdates to addLayerUpdate. #28679

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

HunterLarco
Copy link
Contributor

It looks like there's a typo added in #27972

The documentation describes the new method addLayerUpdate which is correctly added to DataArrayTexture but is incorrectly named addLayerUpdates in CompressedArrayTexture.

Normally I'd be worried about making a backwards incompatible change, however, this feature has only been in the wild for ~2 weeks, is documented under the name addLayerUpdate and any typescript users will not be able to use the feature at all due to a mismatch between the typescript definition and actual code. Knowing this, I'd recommend we fix the typo.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
679.4 kB (168.3 kB) 679.4 kB (168.3 kB) -1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.4 kB (110.4 kB) 457.4 kB (110.4 kB) +0 B
@Mugen87 Mugen87 added this to the r166 milestone Jun 17, 2024
@Mugen87 Mugen87 changed the title Rename addLayerUpdates to addLayerUpdate Jun 17, 2024
@Mugen87 Mugen87 merged commit af083e1 into mrdoob:dev Jun 17, 2024
12 checks passed
@HunterLarco HunterLarco deleted the hunter/fix-typo branch June 17, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants