USDZLoader: Support quads as triangles. #28648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Jun 13, 2024
| const d = rawIndices[ stride + 3 ]; | ||
|
|
||
| indices.push( a, b, c ); | ||
| indices.push( a, c, d ); |
There was a problem hiding this comment.
@Mugen87 I vaguely recall this being better, but I have been unable to locate a reference...
indices.push( a, b, c );
indices.push( c, d, a );Maybe someone else knows if it is true.
There was a problem hiding this comment.
For the reference, LWOLoader splits up its quads with the same strategy like USDZLoader:
three.js/examples/jsm/loaders/LWOLoader.js
Lines 812 to 823 in 3ea9856
If it turns out (c,d,a) is better, I'm happy to update the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28639 (comment)
Description
The PR ensures
USDZLoadercan load assets with quads definitions.