USDZLoader: Fix geometry and material parsing. #28647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Jun 13, 2024
| @@ -675,24 +687,6 @@ class USDZLoader extends Loader { | |||
|
|
|||
| } | |||
|
|
|||
| if ( 'def Shader "diffuseColor_texture"' in data ) { | |||
There was a problem hiding this comment.
These hardcoded shader evaluations were required since the actual shader had a different name than PreviewSurface and thus was not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR adds two fixes. It ensures
buildMaterial()does not always use the namePreviewSurfaceto select the surface shader but uses the real name from the connection definition. Besides, it rearranges index processing inbuildGeometry()to fix normal generation with assets exported fromUSDZExporter.