Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Override alpha channel to 1 for opaque materials #28646

Merged
merged 2 commits into from
Jun 13, 2024
Merged

WebGPURenderer: Override alpha channel to 1 for opaque materials #28646

merged 2 commits into from
Jun 13, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #28645

Fix #28645. Respect the WebGLRenderer by overriding the diffuse alpha channel to 1 for opaque materials.

This contribution is funded by Utsubo
@RenaudRohlinger RenaudRohlinger mentioned this pull request Jun 13, 2024
Closed
@RenaudRohlinger RenaudRohlinger added this to the r166 milestone Jun 13, 2024
@0b5vr
Copy link
Collaborator

0b5vr commented Jun 13, 2024 •
edited
Loading

According to the current code of WebGLPrograms, the OPAQUE flag also needs material.blending === NormalBlending and material.alphaToCoverage === false, I'm not sure how it affects though.
@RenaudRohlinger
Copy link
Collaborator Author

Nice catch @0b5vr! I updated the PR accordingly.
@RenaudRohlinger RenaudRohlinger merged commit 6c8ff24 into mrdoob:dev Jun 13, 2024
11 checks passed
0b5vr added a commit to pixiv/three-vrm that referenced this pull request Jun 20, 2024
@0b5vr
feat: MToonNodeMaterial, move opaque stuff from setupOutput to setupD…
88f35ac 
…iffuseColor

following the Three.js side change
See: mrdoob/three.js#28646
@0b5vr 0b5vr mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@RenaudRohlinger @0b5vr @Mugen87