Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Enhance GLSL Error in WebGLBackend #28594

Merged
merged 6 commits into from
Jun 14, 2024
Merged

WebGPURenderer: Enhance GLSL Error in WebGLBackend #28594

merged 6 commits into from
Jun 14, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Jun 10, 2024 •
edited
Loading

Description

This PR improve the errors in the WebGL backend.

Before this PR:
Screenshot 2024-06-10 at 10 18 27
After this PR:
image

This contribution is funded by Utsubo
@RenaudRohlinger RenaudRohlinger changed the title WebGPURenderer: Improve TSL debugging Jun 10, 2024
@RenaudRohlinger RenaudRohlinger added this to the r166 milestone Jun 10, 2024
@RenaudRohlinger RenaudRohlinger added WebGPU TSL Three.js Shading Language labels Jun 10, 2024
@sunag
Copy link
Collaborator

sunag commented Jun 10, 2024

It seems great to improve the error message, but having the code output in object.outputCode seems like a bit hack to me. Maybe you could split this into two steps and we could think little more about outputCode alternatives?
@sunag
Copy link
Collaborator

sunag commented Jun 10, 2024

Maybe a renderer function like renderer.onCompile( object, shader )
@RenaudRohlinger RenaudRohlinger changed the title WebGPURenderer: Improve Shader Debugging Jun 14, 2024
@RenaudRohlinger
Copy link
Collaborator Author

Ok! I isolated the GLSL error part for this PR.
Will think about a different API for the node part. 👍
@RenaudRohlinger RenaudRohlinger added WebGL Backend and removed WebGPU TSL Three.js Shading Language labels Jun 14, 2024
@RenaudRohlinger RenaudRohlinger merged commit 62fa25e into mrdoob:dev Jun 14, 2024
11 checks passed
This was referenced Jun 20, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGL Backend
2 participants
@RenaudRohlinger @sunag