WebGPURenderer: Pipelines - Clean up. #28495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methuselah96
commented
May 27, 2024
| @@ -67,7 +67,7 @@ class Pipelines extends DataMap { | |||
|
|
|||
| if ( pipeline === undefined ) { | |||
|
|
|||
| if ( previousPipeline && previousPipeline.usedTimes === 0 ) this._releasePipeline( computeNode ); | |||
| if ( previousPipeline && previousPipeline.usedTimes === 0 ) this._releasePipeline( previousPipeline ); | |||
There was a problem hiding this comment.
I think this is just a typo? this._releasePipeline takes a pipeline and uses its cacheKey property to remove it from this.caches.
Methuselah96
commented
May 27, 2024
| @@ -205,7 +205,7 @@ class Pipelines extends DataMap { | |||
|
|
|||
| } | |||
|
|
|||
| super.delete( object ); | |||
| return super.delete( object ); | |||
There was a problem hiding this comment.
This method is overriding DataMap.delete which returns the value for the deleted key. For consistency with how the base method works, it seems best to continue returning the deleted value.
Methuselah96
force-pushed
the
gpu-pipelines-cleanup
branch
from
1c4e8d3
to
83783da
Compare
Methuselah96
commented
May 27, 2024
| @@ -22,6 +22,8 @@ class Attributes extends DataMap { | |||
|
|
|||
| } | |||
|
|
|||
| return attributeData; | |||
There was a problem hiding this comment.
Updated another case where DataMap.delete is being overridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
See comments explaining each change.