Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: default setColorAt to white #28416

Merged
merged 2 commits into from
May 18, 2024

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #28255

Description

Previously the color would default to black for all objects if only a single color was assigned. This defaults the color to white so the material color is used by default.

@gkjohnson gkjohnson added this to the r165 milestone May 18, 2024
@gkjohnson gkjohnson changed the title BatchedMesh: default color to white May 18, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
678.8 kB (168.2 kB) 678.9 kB (168.2 kB) +105 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
456.9 kB (110.3 kB) 456.9 kB (110.3 kB) +0 B
@gkjohnson gkjohnson merged commit d6c3bcc into mrdoob:dev May 18, 2024
12 checks passed
@gkjohnson gkjohnson deleted the default-batch-color branch May 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants