WebGPURenderer: copyTextureToTexture subframe upload and new API #28315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
May 8, 2024
|
I would propose something similar in |
|
Sounds good 👍 |
This was referenced May 18, 2024
Merged
Methuselah96
added a commit
to Methuselah96/three.js
that referenced
this pull request
May 18, 2024
The third argument passed to `copyTextureToTexture` should be a `Box2` or `null`. I believe this is an oversight in mrdoob#28315.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #28281
Description
Align
WebGPURenderer.copyTextureToTextureAPI with theWebGLRenderer.This contribution is funded by Utsubo