Editor: Fixed uncaught exception when environment/background combination is illegal #28300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues:
Currently it causes error when environment is BACKGROUND and background is not TEXTURE|EQUIRECT; If it happens, users have no clue about the failure because the error is only shown in console:![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/1063018/328340687-8f492f86-dd5a-4598-8af7-2b94bef42e0c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3MTMzNzAsIm5iZiI6MTcyMjcxMzA3MCwicGF0aCI6Ii8xMDYzMDE4LzMyODM0MDY4Ny04ZjQ5MmY4Ni1kZDVhLTQ1OTgtOGFmNy0yYjk0YmVmNDJlMGMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDNUMTkyNDMwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTg5MzMxYWEwNTFkZjc1OTM4NjE0ZWM1NGViNTc2NWFmM2RjNjVkY2JlMzlmZGE2YWVjNjc0ZDc2NTQzZmMxNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.BS8otfeuenKiPeMy7xJvuaYk5MftXKuJkUq2boQHROk)
Environment will be unlinked from background when recovering from IndexedDB, i.e. environment can never be 'BACKGROUND' after recovering.
This PR fixed 1 by checking If environment/background combination is illegal, then highlight the environment selector in UIhttps://github.com/mrdoob/three.js/assets/1063018/4aa0f62a-8166-400d-a767-25859eef1e18This PR fixed 1 by handling exception of illegal combinations.
This PR fixed 2 by checking if environment.uuid is equal to background.uuid, then set environment value to
BACKGROUND
Preview: https://raw.githack.com/ycw/three.js/editor-handle-scene-env-exception/editor/index.html