Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: No pollute Number's prototype #28262

Merged
merged 1 commit into from
May 3, 2024
Merged

Editor: No pollute Number's prototype #28262

merged 1 commit into from
May 3, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 2, 2024

With this PR, number formatting is now easier to reason about:

1/ The fn is now from editor.utils instead of Number's prototype
2/ For grouping, uses Intl module instead of regex
@Mugen87 Mugen87 added this to the r165 milestone May 3, 2024
@Mugen87 Mugen87 merged commit a980f81 into mrdoob:dev May 3, 2024
7 of 11 checks passed
@ycw ycw deleted the no-pollute-proto branch May 3, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@ycw @Mugen87