Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Initialize UIs in user preferred language on the first run #28254

Merged
merged 1 commit into from
May 2, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 1, 2024

This PR inits UIs in user-preferred lang on the first run (i.e. when localStorage is empty); fallback to en if lang isn't fr | ja | zh.

To test:

  1. Go to browser settings, set preferred language to Japanese, then
  2. Open https://raw.githack.com/ycw/three.js/autodetect-ui-lang/editor/index.html in incognito mode (mimic first run), then
  3. UIs should be shown in Japanese
@Mugen87 Mugen87 added this to the r165 milestone May 1, 2024
@Mugen87 Mugen87 merged commit 01bc290 into mrdoob:dev May 2, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants