WebGPUBackend: Remove unnecessary use of GPUAdapter (2) #28217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebGPUBackend should only need a GPUDevice to manage resources and check features.
Mugen87
approved these changes
Apr 25, 2024
|
Maybe the most "correct" way to implement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28208
Description
Fix
hasFeatureAsync()of #28208 PR.GPUSupportedFeaturescan be found indeviceandadapter, this PR fix the example ofwebgpu_loader_gltf_compressedand maintains the original idea of the previous PR #28208.