Editor: use importmap for app/index.html
#28195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For testing: https://rawcdn.githack.com/linbingquan/three.js/dev-editor-app/editor/index.html A published app works as before (assuming it is hosted on a web sever) so the PR is fine. I guess we have to move to import maps if we want to include addons in published apps which is required for area light or text geometry. |
Mugen87
approved these changes
Apr 23, 2024
Yeah, you're right. That's exactly what I was thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
As the title says.
app/index.htmlhas usescript type="module", that means the app it requireshttp service.The PR should be OK, Correct me if I'm wrong, I will close it.