WebGLRenderer: Simplify getContext().
#28186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The null check seems to have been redundant. This code should behave the same as the previous code and return `null` when `context === null` or return `context` otherwise. Maybe there is a good reason it was like it was (ability to put a debugger on line 227?) in which case feel free to decline this PR - I just came across the code when I was searching for something else and thought I'd clean it up in case it was unnecessarily there based on a historical change...
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Seems like we don't even need the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
The null check seems to have been redundant.
This code should behave the same as the previous code and return
nullwhencontext === nullor returncontextotherwise.Maybe there is a good reason it was like it was (ability to put a debugger on line 227?) in which case feel free to decline this PR - I just came across the code when I was searching for something else and thought I'd clean it up in case it was unnecessarily there based on a historical change...
Sidenote: I tried running
npm run lint-fixas mentioned inCONTRIBUTING.mdbut that changed some unrelated filesso I didn't commit them.