Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: PMREMGenerator use textureGrad #28181

Merged
merged 2 commits into from
Apr 22, 2024
Merged

WebGPURenderer: PMREMGenerator use textureGrad #28181

merged 2 commits into from
Apr 22, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Apr 22, 2024

Related issue: #27829, #28048

Description

Reference:

three.js/src/renderers/shaders/ShaderChunk/cube_uv_reflection_fragment.glsl.js

Lines 107 to 111 in 4d2add2

#ifdef texture2DGradEXT
return texture2DGradEXT( envMap, uv, vec2( 0.0 ), vec2( 0.0 ) ).rgb; // disable anisotropic filtering
#else

@sunag sunag marked this pull request as ready for review April 22, 2024 00:40
@sunag sunag added this to the r164 milestone Apr 22, 2024
@sunag sunag merged commit 09f9fff into mrdoob:dev Apr 22, 2024
11 checks passed
@sunag sunag deleted the dev-pmrem-grad branch April 22, 2024 01:33
@RenaudRohlinger
Copy link
Collaborator

Happy to see textureGrad beneficial! 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@sunag @RenaudRohlinger