Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLTextures: Fix gl.invalidateFramebuffer() call. #28139

Merged
merged 1 commit into from
Apr 15, 2024
Merged

WebGLTextures: Fix gl.invalidateFramebuffer() call. #28139

merged 1 commit into from
Apr 15, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 15, 2024

Related issue: see #28132 (comment)

Description

This PR makes sure gl.invalidateFramebuffer() is only called when supportsInvalidateFramebuffer is set to true.
@Mugen87 Mugen87 added this to the r164 milestone Apr 15, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
673.6 kB (166.9 kB) 673.6 kB (166.9 kB) +3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
453.3 kB (109.5 kB) 453.4 kB (109.5 kB) +3 B
@Mugen87 Mugen87 merged commit 8c55e3e into mrdoob:dev Apr 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@Mugen87