Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Add (u)int16 Support #28008

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Mar 26, 2024

Description

This PR adds the support to int16 and uint16 to the WebGL Backend and also handle automatically the conversion to int32 and uint32 typed arrays in WebGPU since 16 format is not available by default.

This contribution is funded by Utsubo

@sunag sunag added this to the r163 milestone Mar 26, 2024
@mrdoob mrdoob merged commit 2309d42 into mrdoob:dev Mar 27, 2024
11 checks passed
@RenaudRohlinger
Copy link
Collaborator Author

Thanks for this @CodyJasonBennett! So if I understand correctly I should also include int8 and uint8?

@CodyJasonBennett
Copy link
Contributor

Linked only for posterity, but I suppose those types would require the same treatment.

@kainino0x
Copy link

Thanks mrdoob for forwarding this issue, I've filed gpuweb/gpuweb#4549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants