Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: delete documentation for deleteGeometry #28004

Merged
merged 1 commit into from
Mar 26, 2024
Merged

BatchedMesh: delete documentation for deleteGeometry #28004

merged 1 commit into from
Mar 26, 2024

Conversation

marwie
Copy link
Contributor

@marwie marwie commented Mar 26, 2024 •
edited by gkjohnson
Loading

Fix #27985
Fix #27897

Description

Since there's currently no valid usecase for calling deleteGeometry without implementation for optimize the method should not show up in the docs

This contribution is funded by 🌵 Needle
gkjohnson
gkjohnson approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@gkjohnson gkjohnson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay to remove from the docs until we add support for an "optimize" function to BatchedMesh.
@gkjohnson gkjohnson added this to the r163 milestone Mar 26, 2024
@gkjohnson gkjohnson merged commit ca14c9e into mrdoob:dev Mar 26, 2024
3 checks passed
@gkjohnson gkjohnson mentioned this pull request Mar 26, 2024
Closed
This was referenced Mar 28, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@marwie @gkjohnson