AnimationClip: default constructor parameters

[trusktr]

Related issue: N/A

Description

This makes AnimationClip easier to use without providing initial arguments, f.e.

const clip = new AnimationClip();

// ...any time later...
clip.tracks.push(...keyframeTracks)
clip.resetDuration()

The above code will currently throw because it tries to calculate duration based on nothing (tracks array is undefined).

Currently we have to do this,

const clip = new AnimationClip('', -1, []);

or this,

const clip = new AnimationClip('', 0);
clip.tracks = []

to successfully be able to do this:

// ...any time later...
clip.tracks.push(...keyframeTracks)
clip.resetDuration()

Sidenote, this new signature happens to match with the type definition in @types/three.

This contribution is funded by Lume (3D HTML)

[github-actions]

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev	Filesize PR	Diff
670.8 kB (166.3 kB)	678.5 kB (168.6 kB)	+7.68 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev	Filesize PR	Diff
450.8 kB (108.9 kB)	458.8 kB (111.4 kB)	+8 kB

[trusktr]

Filesize dev Filesize PR Diff
450.8 kB (108.9 kB) 458.8 kB (111.4 kB) +8 kB

What's the +8kb?

[Mugen87]

You are targeting the master branch, not dev. Let me fix this.

[trusktr]

You are targeting the master branch, not dev. Let me fix this.

Ah thanks! I see what happened:

• the "Source" links on threejs.org point to files on master,
• I clicked the edit button and edited in the GitHub UI
• this resulted in the subsequent pull request base being master by default.

I'll keep this in mind. Should the Source links be set to point to dev?

[Mugen87]

The source links should should point to pages which reflect the latest version of the release so pointing to dev could be confusing, imo.