WebGPURenderer: Prevent PMREM to break when missing textures #27951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
RenaudRohlinger
commented
Mar 20, 2024
| @@ -109,7 +109,7 @@ | |||
|
|
|||
| // renderer | |||
|
|
|||
| renderer = new WebGPURenderer( { antialias: true } ); | |||
| renderer = new WebGPURenderer( { antialias: true, forceWebGL: false } ); | |||
There was a problem hiding this comment.
I forgot to remove this line but this basically does nothing (WebGPURenderer will still fallback to webgl if the webgpu context is not available) so I will include a patch in another PR later.
There was a problem hiding this comment.
Fix in #27952
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27829
Description
Fix
webgpu_cubemap_adjustments,webgpu_cubemap_dynamic,webgpu_cubemap_mixandwebgpu_parallax_uv, introduceloadCubemapAsyncand throw error if a texture from a CubeMap is not loaded yet while trying to be used byPMREMNode.Basically the material was trying to use the envmap generated by
RGBMLoaderbut some texture from theCubeMapwere not resolved yet. It was returning some empty values in the array making it difficult to identify so I now initialize toundefinedthe images inRGBMLoader. Also added a check for basic envmap.If a texture is missing we now throw an error like so:
/cc @sunag
This contribution is funded by Utsubo