Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShaderLib: Clean up #27936

Merged
merged 1 commit into from
Mar 18, 2024
Merged

ShaderLib: Clean up #27936

merged 1 commit into from
Mar 18, 2024

Conversation

WestLangley
Copy link
Collaborator

Minor cleanup.
@WestLangley WestLangley added this to the r163 milestone Mar 17, 2024
WestLangley
WestLangley commented Mar 17, 2024
View reviewed changes
src/renderers/shaders/ShaderLib.js
@@ -93,7 +93,7 @@ const ShaderLib = {
emissive: { value: /*@__PURE__*/ new Color( 0x000000 ) },
roughness: { value: 1.0 },
metalness: { value: 0.0 },
envMapIntensity: { value: 1 } // temporary
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I market this as 'temporary' in the original MeshStandardMaterial PR (#7381) because I felt the environmant map intensity should be a property of the environment map, not the material.

But it has turned out not to be temporary after all...
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
670.3 kB (166.2 kB) 670.3 kB (166.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
450.6 kB (108.9 kB) 450.6 kB (108.9 kB) +0 B
@Mugen87 Mugen87 merged commit e6fb47d into mrdoob:dev Mar 18, 2024
12 checks passed
@WestLangley WestLangley deleted the dev--shaderlib_cleanup branch March 18, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@WestLangley @Mugen87