WebGPURenderer: Add Timestamp Queries WebGL fallback support #27870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
approved these changes
Mar 6, 2024
This was referenced Mar 8, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality to measure the execution time of programs on the GPU within the WebGL Backend by using the
EXT_disjoint_timer_query_webgl2extension.This feature is useful for benchmarking performance disparities between the WebGPU and WebGL Backends.
As an example I updated
webgpu_storage_bufferto use thetrackTimestampparameter, WebGPU is on the left and WebGL and the right:https://raw.githack.com/renaudrohlinger/three.js/feat/utsubo/timestamp-webgl/examples/webgpu_storage_buffer.html
PS:
Please note that the WebGL performances appears to consistently take approximately 5 to 10 times longer than its WebGPU counterpart. Despite thorough verification to ensure accuracy in the implementation, this discrepancy persists. My hypothesis would be that the additional time consumed by WebGL may be attributed to the security validations performed with each WebGL instruction.
Related:
#27597
This contribution is funded by Utsubo