Material: Fix emissiveIntensity not persisting.
#27769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Material with an `emissiveIntensity` of 0 is serialized, the previous truthy check does not persist this field. It will get reset to the default of 1 when loaded by the `ObjectLoader`. Solution: Be explicit and add `!== undefined` (same as specularIntensity).
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
gkjohnson
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
If a Material with an
emissiveIntensityof 0 is serialized, the previous truthy check does not persist this field. It will get reset to the default of 1 when loaded by theObjectLoader.Solution: Be explicit and add
!== undefined(same as specularIntensity).