Quaternion: correct the quaternion random() method #27724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
WestLangley
force-pushed
the
dev-quaternion_random
branch
2 times, most recently
from
6864128
to
d52a4dc
Compare
Mugen87
approved these changes
Feb 11, 2024
|
|
|
Regarding #27725 (comment). @WestLangley Do you have the same issue in this PR as well? |
|
Maybe you have not updated the builds before generating the screenshots? That happened to me last time. |
|
Yes, same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #22494
The current code references an outdated link, which implemented an algorithm using a different quaternion convention.
This PR references the the original source, and follows the original sources's nomenclature. The original source and three.js use the same [ x, y, z, w ] quaternion convention.