Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLState: Check WEBGL_draw_buffers extension before calling drawBuffersWEBGL(). #27693

Merged
merged 1 commit into from
Feb 6, 2024
Merged

WebGLState: Check WEBGL_draw_buffers extension before calling drawBuffersWEBGL(). #27693

merged 1 commit into from
Feb 6, 2024

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Feb 6, 2024

Description

There are two places have called state.drawBuffers, but only the one in WebGLRenderer has check drawBuffers, other one hasn't.
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
676 kB (167.9 kB) 676.2 kB (167.9 kB) +155 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
456.6 kB (110.7 kB) 456.8 kB (110.7 kB) +155 B
@Mugen87 Mugen87 added this to the r162 milestone Feb 6, 2024
@Mugen87 Mugen87 changed the title fix: check WEBGL_draw_buffers before call drawBuffersWEBGL Feb 6, 2024
@Mugen87 Mugen87 merged commit 6826426 into mrdoob:dev Feb 6, 2024
12 checks passed
@susiwen8 susiwen8 deleted the drawBuffers branch February 6, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@susiwen8 @Mugen87