Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix ambiguous field in WebGL Backend #27619

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

@RenaudRohlinger RenaudRohlinger commented Jan 25, 2024

Not sure what is the purpose of labeling in that context but using cameraProjectionMatrix in a tslFn that then gets translated to a fragment shader seems to break in the WebGL Backend in Google Chrome (not Firefox).

Removing the labels seems to fix the issue.

image

This contribution is funded by Utsubo

@sunag sunag changed the title WebGPURenderer: Fix ambious field in WebGL Backend Jan 25, 2024
@sunag
Copy link
Collaborator

sunag commented Jan 25, 2024

Interesting, this was used for debugging purposes and could be removed.
I think we will have to go back to this especially when we return to the development of UniformGroup, this shouldn't happen.

@sunag sunag added this to the r161 milestone Jan 25, 2024
@sunag sunag merged commit bd33e67 into mrdoob:dev Jan 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants