Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLTextures: Add filter check for float textures. #27460

Merged
merged 1 commit into from
Dec 28, 2023
Merged

WebGLTextures: Add filter check for float textures. #27460

merged 1 commit into from
Dec 28, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 28, 2023

Fixed #27434.

Description

This PR makes sure WebGLRenderer provides a warning if float textures are used with linear filtering without the OES_texture_float_linear extension. This is a common issue on Apple devices so a separate warning hopefully helps developers .
@Mugen87 Mugen87 added this to the r161 milestone Dec 28, 2023
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
670.7 kB (166.7 kB) 671 kB (166.8 kB) +350 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
451.5 kB (109.7 kB) 451.9 kB (109.8 kB) +358 B
@Mugen87 Mugen87 merged commit 4a73862 into mrdoob:dev Dec 28, 2023
12 checks passed
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
@Mugen87 @AdaRoseCannon
WebGLTextures: Add filter check for float textures. (mrdoob#27460)
877e606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@Mugen87