Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitControls: fix pinch zoom behaviour #27446

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

sciecode
Copy link
Contributor

Related: #27418

  • Handles pinch zoom trackpad behaviour, by intercepting Ctrl keydown and properly adjusting delta scale.
  • Correctly handles different WheelEvent.deltaMode (Line, Page)

misc_controls_map - PR Example

We might want to push this commit with patch r160.1

Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
@mrdoob mrdoob added this to the r161 milestone Dec 28, 2023
@mrdoob mrdoob merged commit dfbee3c into mrdoob:dev Dec 28, 2023
11 checks passed
@sciecode sciecode deleted the dev-orbit-pinch branch December 28, 2023 15:45
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
mrdoob pushed a commit that referenced this pull request Jan 22, 2024
Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
mrdoob pushed a commit that referenced this pull request Jan 22, 2024
Signed-off-by: Guilherme Avila <3927951+sciecode@users.noreply.github.com>
@mrdoob
Copy link
Owner

mrdoob commented Jan 22, 2024

This PR is part of 0.160.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants