SVGLoader: Update vertices according uv.y when linecap is square #27429
Conversation
| @@ -3082,7 +3082,8 @@ class SVGLoader extends Loader { | |||
| } else { | |||
|
|
|||
| tempV2_3.toArray( vertices, 1 * 3 ); | |||
| tempV2_3.toArray( vertices, 3 * 3 ); | |||
| // using tempV2_4 to update 3rd vertex if the uv.y of 3rd vertex is 1 | |||
There was a problem hiding this comment.
The PR indeed fixes the issue and I don't see any regressions in webgl_loader_svg.
Do you mind explaining the reasoning behind this change though? Why does the code have to make a distinction at this line?
There was a problem hiding this comment.
tempV2_3 and tempV2_4 are the two new vertices after the cap is calculated. They should replace the corresponding old vertices. Updates to tempV2_3 and tempV2_4 are explicit. But there are two cases of updating vertices[3] with tempV2_3 or tempV2_4.
uv.y is used to determine whether to use tempV2_3 or tempV2_4.
There was a problem hiding this comment.
It would be better if there was no need to make a distinction. Maybe there's a better way?
There was a problem hiding this comment.
Not sure. If somebody comes up with a uniform approach, we can sill update the code. For now, let's go with the this PR.
fix #26781