Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sphere: Add isSphere flag. #27395

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Sphere: Add isSphere flag. #27395

merged 1 commit into from
Dec 18, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 18, 2023 •
edited
Loading

Fixed #27386.

Description

Adds isSphere to Sphere to enable type detection like with other classes.
@Mugen87 Mugen87 added this to the r160 milestone Dec 18, 2023
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
668.9 kB (166.1 kB) 669 kB (166.1 kB) +17 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.8 kB (109 kB) 449.8 kB (109 kB) +17 B
@Mugen87 Mugen87 merged commit 722bb09 into mrdoob:dev Dec 18, 2023
12 checks passed
This was referenced Dec 19, 2023
Closed
Merged
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
@Mugen87 @AdaRoseCannon
Sphere: Add isSphere flag. (mrdoob#27395)
158d025
@gouldingken gouldingken mentioned this pull request Jun 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Mugen87 @gkjohnson