Fix: CSM lights when shadow maps are disabled #27358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndrejSpanel
force-pushed
the
fix-csm-shadows-disabled
branch
from
d5cb6d3
to
ebbc449
Compare
OndrejSpanel
force-pushed
the
fix-csm-shadows-disabled
branch
from
ebbc449
to
8ff00cd
Compare
OndrejSpanel
force-pushed
the
fix-csm-shadows-disabled
branch
from
8ff00cd
to
cdad72c
Compare
Mugen87
approved these changes
Dec 11, 2023
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* Fix indentation * Allow shadows to be disabled from GUI * Fix: when shadows are disabled, light contribution still needs to be considered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #27338
Description
Even when the shadows are not computed, the light contribution needs to be added.
Fixed example: https://raw.githack.com/ondrejspanel/three.js/fix-csm-shadows-disabled/examples/webgl_shadowmap_csm.html
Note: as shown in the linked issue, I have also included an option to toggle shadows on / off. I think it does no harm, it is something users can play with in the sample and it makes verification of the fix much easier.