DracoLoader: Fix not calling onError().
#27306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Dec 4, 2023
Mugen87
reviewed
Dec 4, 2023
Mugen87
approved these changes
Dec 4, 2023
|
Let's give this a try! |
donmccurdy
reviewed
Dec 4, 2023
13 tasks
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* fix onError load
* onError
* LinearSRGBColorSpace instead of undefined
* default onError = () => {}; call onError to cleanup code;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #20883
Description
I'm aware the dracoLoader might be getting a refactor sometime in the future, however in the meantime, this needed to be addressed;
The problem is that the onError is never called on failed DracoLoader load;
This PR fixes this issue by passing the promise reject to the onError argument
Please feel free to edit this PR if needed.