Examples: bump @monogrid/gainmap-js to v3.0.0 in webgl_loader_texture_hdrjpg.html #27277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneration using an equirectangular rendertarget with mipmaps
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
…eneration using an equirectangular rendertarget with mipmaps (mrdoob#27277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Issue in gainmap-js repository
Description
This fixes a problem in this specific example (the root cause of the problem in the three.js library remains unknown) where WebGLCubeMap generation using an Equirectangular renderTarget (allowed by #27230) with
generateMipmaps = truecaused visual artifacts (see below).Our library now doesn't create renderTargets with
generateMipmaps = trueby default anymore, this solves this specific problem in this example.before
after
The example is now updated and working as intended (plus I added
dispose()methods, which free up GPU memory)