Docs: Improve LineDashedMaterial page.
#27276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Nov 29, 2023
| @@ -12,7 +12,8 @@ | |||
| <h1>[name]</h1> | |||
|
|
|||
| <p class="desc"> | |||
| A material for drawing wireframe-style geometries with dashed lines. | |||
| A material for drawing wireframe-style geometries with dashed lines.<br /> | |||
| Note: Make sure to call [page:Line.computeLineDistances]() when using [name]. | |||
There was a problem hiding this comment.
An argument can be made that "Be sure to call" is more appropriate here. But I think a better way to say it is:
Note: You must call page:Line.computeLineDistances when using [name].
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27255
Description
Adds a note to the
LineDashedMaterialpage thatLine.computeLineDistances()has to be used with this material type.