Editor: Fix multi-material support. #27265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://rawcdn.githack.com/Mugen87/three.js/dev78/editor/index.html You can test the PR with the FBX asset from #27259 (comment). |
|
Added the PR to the |
LeviPesin
reviewed
Jan 14, 2024
| function update( currentObject, currentMaterialSlot = 0 ) { | ||
|
|
||
| object = currentObject; | ||
| materialSlot = currentMaterialSlot; | ||
|
|
||
| if ( object === null ) return; | ||
| if ( object.material === undefined ) return; |
There was a problem hiding this comment.
Is this a correct check if now different expression is assigned to material? /ping @Mugen87
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
While debugging the FBX asset from #27259, I have noticed multi material support in the editor is broken. I have fixed the material panel except for the script section (since objects with multiple (raw) shader materials can't be configured anyway).
The basic idea of this PR is to use the
materialSlotvalue not only in the commands but in the property classes as well in order to select the correct material.