WebGLUniforms: Add sampler2DShadow support.
#27252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
![github-advanced-security[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Mugen87
reviewed
Nov 29, 2023
Mugen87
reviewed
Nov 30, 2023
Mugen87
approved these changes
Nov 30, 2023
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* add support for sampler2DShadow in uniforms * Update WebGLUniforms.js * use gl.SAMPLER_2D_SHADOW instead * Update WebGLUniforms.js --------- Co-authored-by: mrdoob <info@mrdoob.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init
sampler2DShadowif the texture is not set yet by the user toWebGLUniforms.Basically if in your shader you're using a
sampler2DShadowand you didn't bind the correct texture format yet, WebGL will not be happy and crash as it will fallback to a basic texture.RequirescompareFuncparameter inDepthTextureconstructor #27251 (otherwise we needneedsUpdate=truewhich is probably something we don't want to add inWebGLUniforms.All these elements are necessary for a better implementation of shadows that I want to introduce in the future that use
sampler2DShadowinstead ofsampler2D.