NodeMaterial: Rename .colorSpace -> .colorSpaced property

[sunag]

Related issue: #26440 (comment)

Description

Folowing the same logic of Material.toneMapped.

[mrdoob]

Hmmm, not sure about these...

• fog
• normals
• lights
• toneMapped
• colorSpaced
• forceSinglePass

Are there any other material booleans like these?

[WestLangley]

I hope someone can suggest a better property name than colorSpaced...

[sunag]

Are there any other material booleans like these?

Some other booleans:

• clipping
• vertexColors
• transparent
• alphaHash
• stencilWrite
• clipShadows
• colorWrite
• dithering
• alphaToCoverage
• premultipliedAlpha

[sunag]

I hope someone can suggest a better property name than colorSpaced...

I don't now if @mrdoob or you prefer applyColorSpace? ( #26440 (comment) ), the prefix apply remember me a function name, but certainly there are others possibilities.

[LeviPesin]

Maybe correctColorSpace/colorSpaceCorrection/colorSpaceCorrected? @sunag @mrdoob @WestLangley

the prefix apply remember me a function name

I guess it is because all function names should be verbs. Not sure what should be these properties -- we already have for example clipShadows (verb) but most are just nouns (alphaToCoverage/dithering/so on).

Maybe something like useFog/useToneMapping/etc?

[WestLangley]

What you are doing is referred to as a color conversion -- converting a color from one color space to another.

.colorConverted ?

But in particular, you are either honoring or ignoring the renderer's output color space. I am inclined to think the API may require a bit more thought...

[LeviPesin]

Hm... Maybe .colorConvert then? But colorConverted also seems OK to me.

[sunag]

But in particular, you are either honoring or ignoring the renderer's output color space. I am inclined to think the API may require a bit more thought...

Some materials in particular like MeshNormalMaterial didn't do exactly this color space conversion, they would by default be colorConverted=false, although to obtain the normals for RenderTargets today with Nodes there are better ways.

I'm considering following this same logic that you mentioned for toneMapped too here #27880

[WestLangley]

@sunag Please keep my suggestion -- or @LeviPesin's alternative -- in mind as you think about this. 😇 .colorSpaced does not have an obvious meaning.