Editor: Fix KTX2 support with glTF assets. #27191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22035
Description
When debugging a glTF asset with the editor, I have noticed the respective KTX2 textures were not displayed. Turns out the call of
detectSupport()was missing. This is now done with a new signal so the editor does not have to create a temporary renderer just for the loader creation.While reviewing my code, I have noticed that
UITextureshould also use the new signal which required a minor refactoring in the constructor (since a reference to theeditorobject is required like inUIOutliner). While doing this, I have removed the unusedUICubeTextureclass as well.