Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshPhysicalMaterial: Fixed anisotropy zero strength. #27164

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

elalish
Copy link
Contributor

@elalish elalish commented Nov 9, 2023

Fixes #26694

Description

@WestLangley You were 100% right - it was just the divide by zero. I'm used to NaNs propogating into completely black pixels, but I guess it must have gotten caught and clamped somewhere else in the shader. But indeed, the problem was only when anisotropy was zero exactly.

Copy link

github-actions bot commented Nov 9, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
656.6 kB (162.7 kB) 656.7 kB (162.7 kB) +96 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
449.1 kB (108.6 kB) 449.2 kB (108.6 kB) +96 B
@mrdoob mrdoob added this to the r159 milestone Nov 9, 2023
@mrdoob mrdoob merged commit 164b23f into mrdoob:dev Nov 9, 2023
20 checks passed
@elalish elalish deleted the anisoStrength branch November 9, 2023 20:36
@Mugen87 Mugen87 changed the title Fixed anisotropy zero strength Nov 10, 2023
@LeviPesin
Copy link
Contributor

Was the ssl change intentional here? /ping @elalish

@elalish
Copy link
Contributor Author

elalish commented Jan 12, 2024

Yes, I swear there was a discussion around it somewhere, but I can't find it now. This makes it so you can serve the examples locally over HTTP without having a bunch of angry browser errors. We couldn't find anything this broke - have you?

@hybridherbst
Copy link
Contributor

Juuust was hunting down this issue. All of the WebXR samples break if the files aren't served via HTTPS locally anymore.
One option is to have two separate commands (one with, one without SSL) for "people who don't want to see a HTTPS warning" vs. "people who want to use HTTPS".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants