Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Fix lights hash #27150

Merged
merged 1 commit into from
Nov 8, 2023
Merged

WebGPURenderer: Fix lights hash #27150

merged 1 commit into from
Nov 8, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 8, 2023

Related issue: Fixes #27069

Description

  • Fix shadow state and remove RTT in case of disuse.
  • Simplifying getCacheKey() a little, I think we can reduce this complexity even further.
  • lightsWithoutWrap() renamed to lightNodes().
@sunag sunag added this to the r159 milestone Nov 8, 2023
@sunag sunag marked this pull request as ready for review November 8, 2023 17:42
@sunag sunag changed the title Renderer: Fix lights hash Nov 8, 2023
@sunag sunag merged commit 8e66fe5 into mrdoob:dev Nov 8, 2023
19 checks passed
Repository owner deleted a comment from jabri62018 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sunag