WebGLRenderer: Add initial support for multi draw BatchedMesh #27111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
gkjohnson
commented
Nov 3, 2023
Comment on lines
+66
to
+71
| let elementCount = 0; | ||
| for ( let i = 0; i < drawCount; i ++ ) { | ||
|
|
||
| elementCount += counts[ i ]; | ||
|
|
||
| } |
There was a problem hiding this comment.
This part is a bit awkward - in order to correctly report the primitive counts drawn we have tally up all the values in the array.
|
Regarding your future PR plans, we might want to consider to move |
Yup! Once I'm finished with the implementation in examples I'll move it. |
This was referenced Nov 5, 2023
This was referenced Nov 7, 2023
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22376, #27078 (comment)
Description
Add support for the multi draw extension to WebGLRenderer via
WebGLIndexedBufferRendererandWebGLBufferRendererforBatchedMesh. The buffers to pass to the multi draw functions are generated in the onBeforeRender function. With this PR non-visible meshes will no longer be rendered at all with the multi draw extension and BatchedMesh will no longer be supported in browsers that do not support the WebGL_multi_draw extension (firefox, opera mobile).Upcoming PR Plans