HTMLMesh: Clear the canvas before starting to draw #27092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can put "HTMLMesh: " in this PR title and others you will do so that's easily searchable and we know right away it's about HTMLMesh. The change makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: AdaRoseCannon/aframe-htmlmesh/pull/20
In related issue, @vincentfretin suggests that a better fix would be to clear the whole canvas every time at the beginning. I think this makes sense, as the mesh is meant to be completely redrawn on update.
The proposed change implements the suggestions and clears the whole canvas first thing before starting to draw.
All the best