HTMLMesh: create canvas in its original position instead of (0,0) #27091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this change also needs to honor the fix from #25930? |
|
Good question. In my use case the offset does not seem to be necessary (e.g. "it works for me"), but to be honest I do not fully understand why this hardcoded 0.5 is needed in the first place... I will be happy to introduce it in case. |
Elettrotecnica
changed the title
|
When reading the code again, it's seems okay as it is. Canvas and images are processed in the same way with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: AdaRoseCannon/aframe-htmlmesh/pull/19 and #25916
Similar to what has been done for images, this change introduces that canvas elements are also rendered in position rather than 0,0
All the best