WebGPURenderer: Support WebGLCubeRenderTarget #27071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aardgoose
force-pushed
the
cube
branch
2 times, most recently
from
379db47
to
a365ac8
Compare
aardgoose
force-pushed
the
cube
branch
5 times, most recently
from
fc913d7
to
cffdad4
Compare
aardgoose
force-pushed
the
cube
branch
3 times, most recently
from
b16a52e
to
d14554a
Compare
|
This one will conflict with #27463. Would be great if we can merge this one before. I will update the other PR once it's done. |
|
/@sunag @RenaudRohlinger Rebased on recent msaa changes - does anyone use/expect msaa on cube textures? |
Considering that MSAA has never been supported on cube textures in Three.js, and we haven't received any complaints or requests for this feature ever, I suggest we refrain from implementing it at this stage. /@aardgoose |
|
@RenaudRohlinger Very happy not to add it, |
added 2 commits
January 3, 2024 13:14
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* cube render targets * implemenet destroyAttribute() * replicate WebGPU texture filtering * missed ; * allow tests to run * reinstate flip * add missing ; * repair damage --------- Co-authored-by: aardgoose <angus.sawyer@email.com>
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to render to WebGLCubeRenderTarget and fixes cubeTexture lookups for WebGL
Also adds mipmap creation for renderTarget textures and minor depthTexture handling.