BatchedMesh: Add thrown errors #27060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
commented
Oct 26, 2023
| @@ -104,7 +104,7 @@ | |||
| geometries = [ | |||
| new THREE.ConeGeometry( 1.0, 2.0 ), | |||
| new THREE.BoxGeometry( 2.0, 2.0, 2.0 ), | |||
| new THREE.SphereGeometry( 1.0 ), | |||
| new THREE.SphereGeometry( 1.0, 16, 8 ), | |||
There was a problem hiding this comment.
With the errors I found that we were overwriting the end of BatchedMesh geometry index in the example - so I simplified the sphere so it has fewer vertices to avoid that case.
Mugen87
reviewed
Oct 26, 2023
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #25059, #22376
Description
cc @takahirox