Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBXLoader: Fix rotation discontinuities. #27057

Merged

Conversation

solinehayes
Copy link
Contributor

@solinehayes solinehayes commented Oct 25, 2023

Fix #27056

Description
This PR addresses an issue in the FBXLoader where rotations with significant differences between consecutive frames were interpolated using Euler angles (each coordinate separately), which could introduce discontinuities. The proposed solution detects and corrects these discontinuities by using quaternion interpolation (taking into account possible unroll/quaternion negation), ensuring smooth rotation.

@Mugen87 Mugen87 changed the title Issue27056 fix rotation discontinuities Oct 25, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 25, 2023

I can confirm that your PR fixes the issue! Great! 🎉

Still it's important to review the new code a bit more closely so let's target r159 for this change.

Side note: The maintenance of FBXLoader is currently a bit tricky since no one of the current active collaborators works at the loader. I have implemented and reviewed a few smaller changes for the loader in the recent past but I'm definitely no FBX expert 😅 . So this PR might take a little bit longer to get reviewed.

I wish we had an additional dev with FBX knowledge who could help out reviewing FBX related PRs.

@Mugen87 Mugen87 added this to the r159 milestone Oct 25, 2023
@WestLangley
Copy link
Collaborator

The maintenance of FBXLoader is currently a bit tricky

Agreed.

@solinehayes Out of curiosity, is using GLB format an acceptable alternate workflow for you -- or is there a particular advantage to FBX format?

GitHubDragonFly added a commit to GitHubDragonFly/GitHubDragonFly.github.io that referenced this pull request Oct 26, 2023
@solinehayes
Copy link
Contributor Author

The maintenance of FBXLoader is currently a bit tricky

Agreed.

@solinehayes Out of curiosity, is using GLB format an acceptable alternate workflow for you -- or is there a particular advantage to FBX format?

Well, I am working in a company where we're using Maya, so we majorly use FBX. We occasionally use GLB but we prefer FBX.
Plus we're working with animation and GLB only allows multiple animations in one asset, we can not animate several character with several animations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants