Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: Add comments, use local variables in functions #27049

Merged
merged 6 commits into from
Oct 25, 2023
Merged

BatchedMesh: Add comments, use local variables in functions #27049

merged 6 commits into from
Oct 25, 2023

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Oct 25, 2023 •
edited
Loading

Related issue: #25059, #22376

Description

Use local variables, add comments, and rearrange deleteGeometry, applyGeometry. The big thing that makes the PR a bit difficult to diff is that the initialization logic when adding a first geometry has been moved to a separate _initializeGeometry function. If needed I can remove that and add it in another PR.

cc @takahirox
@gkjohnson gkjohnson added this to the r158 milestone Oct 25, 2023
@Mugen87 Mugen87 merged commit 3df4df2 into mrdoob:dev Oct 25, 2023
19 checks passed
@gkjohnson gkjohnson deleted the batch-mesh-cleanup branch October 25, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@gkjohnson @Mugen87