Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Assign SRGBColorSpace only to color maps. #27042

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Editor: Assign SRGBColorSpace only to color maps. #27042

merged 1 commit into from
Oct 25, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 24, 2023 •
edited
Loading

Related issue: #16148

Description

Since #16148 the editor assigns SRGBColorSpace to all textures configured via the UI. This isn't right since only color maps should have SRGBColorSpace assigned to their colorSpace property.
@Mugen87 Mugen87 added this to the r158 milestone Oct 24, 2023
@Mugen87 Mugen87 merged commit 6fb6f43 into mrdoob:dev Oct 25, 2023
19 checks passed
@CodyJasonBennett CodyJasonBennett mentioned this pull request Oct 26, 2023
Open
@CodyJasonBennett CodyJasonBennett mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@Mugen87